-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bulk_delete_vulnerabilities): pass delete API endpoint Url #262
Conversation
…parameter function in the bulk delete button
Reviewer's Guide by SourceryThis pull request fixes the bulk delete vulnerabilities feature by adding a missing 'data-url' attribute to the bulk delete button, ensuring the button points to the correct API endpoint. The fix addresses the bug where requests were sent to /undefined, preventing the proper deletion of vulnerabilities. Sequence diagram for Bulk Delete Vulnerabilities API CallsequenceDiagram
actor User
participant Button as Bulk Delete Button
participant API as Vulnerability API Endpoint
User->>Button: Click 'Bulk Delete Vulnerabilities'
Button->>API: Send POST to /api/action/vulnerability/delete/
API-->>Button: Return deletion result
Button-->>User: Display success/failure feedback
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @0b3ud - I've reviewed your changes - here's some feedback:
Overall Comments:
- Fix the typo in the button label from 'Bulk Delete Vulneraties' to 'Bulk Delete Vulnerabilities'.
- If applicable, consider externalizing the API endpoint URL into a config or constant for easier future updates.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the template function url to refer to the route, not the value hard coded in the template.
And update the typo in the button name, it says vulneraties instead of vulnerabilities
Fixed the typo and used the template function url to refer to the route as required :) |
Fix #260
Bug :
Fix details :
Summary by Sourcery
Bug Fixes: