Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using keyboard arrow keys to navigate Project pane, File Preview grabs focus on second file visited #48

Closed
bronius opened this issue Oct 11, 2019 · 3 comments · Fixed by #69
Closed

Using keyboard arrow keys to navigate Project pane, File Preview grabs focus on second file visited #48

bronius opened this issue Oct 11, 2019 · 3 comments · Fixed by #69
Assignees
@SeeSharpSoft
Labels
bug Something isn't working in development Marker to avoid double effort

Comments

@bronius
Copy link

bronius commented Oct 11, 2019 •
edited
Loading

(see screencast)
quick-file-preview-focus-grab

In the above screencast, I have focus on a folder, arrow down a few times, first non-folder file opens Preview, next non-folder file also opens in Preview but also loses focus. I click a folder to repeat/resume keyboard, same thing.. click one more time this time into file, same thing.
@SeeSharpSoft
Copy link
Owner

SeeSharpSoft commented Oct 17, 2019 •
edited
Loading

Thanks for reporting and the screencast. The editor focus is a tricky one - I couldn't figure out a proper focus behavior yet that works well in every scenario (see #29, #43, #44). I'll keep on investigating.

@SeeSharpSoft SeeSharpSoft added the bug Something isn't working label Oct 17, 2019
@oxysoft
Copy link

oxysoft commented Oct 23, 2019

Also getting this, making the plugin pretty unusable sadly. Hoping it can be fixed!

@SeeSharpSoft SeeSharpSoft self-assigned this Oct 24, 2019
@SeeSharpSoft SeeSharpSoft added the in development Marker to avoid double effort label Oct 24, 2019
@kxalex
Copy link

kxalex commented Nov 27, 2019

Looks like it's conflicting with "Autoscroll from source". Try to disable it as it worked for me.

But still, I do want to have it enabled + preview files going through tree.

Looking forward for a fix.

SeeSharpSoft added a commit that referenced this issue Apr 18, 2020
@SeeSharpSoft
[FIX] better preview handling with respect to file history, navigatio…
267348a 
…n & "Scroll from Source"

Fixes #48
Fixes #67
@SeeSharpSoft SeeSharpSoft mentioned this issue Apr 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SeeSharpSoft SeeSharpSoft

Labels
bug Something isn't working in development Marker to avoid double effort
Projects
None yet
Milestone
No milestone
4 participants
@kxalex @bronius @SeeSharpSoft @oxysoft