Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase SPIDEV buffer size to 128k on pi0 board #55

Merged
merged 1 commit into from
Aug 6, 2023

Conversation

newtonick
Copy link
Collaborator

See SeedSigner/seedsigner#420

TLDR: provides modest performance gain when refreshing the display

@jdlcdl
Copy link

jdlcdl commented Aug 3, 2023

I used your changes for pi0 and pi0-dev for pi2 and pi2-dev (which are still needed).

I already had a container built for pi2-dev so I built with no-clean and used ss's latest pr420 at 32eda52.

This pr by itself is noticeably faster. (ack as soon as other boards are updated, but pi2 works great).

@newtonick
Copy link
Collaborator Author

Do we want this update in other boards without addressing frame rate and button hold timing concerns?

My thought was to do other boards in a separate PR.

@jdlcdl
Copy link

jdlcdl commented Aug 3, 2023

I'll get a pi0 container going.

Now that I have a pi0 container again.

ACK tested

...on pi0 using ss's latest pr420 at 32eda52
...and at 327662 with fps at 6. Now it feels like a pi2. I got 6.05 fps when I enabled show_framerate in scan_screens. And the screensaver looks a bit nervous/anxious/hyper, but much smoother

@newtonick newtonick merged commit 89096c2 into SeedSigner:main Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants