Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Open Pill Enclosure Notes to include "comfort" joystick modification #362

Merged
merged 10 commits into from
May 23, 2023

Conversation

bitcoinprecept
Copy link
Contributor

I am proposing an update to the Open Pill enclosure notes that details a DIY option for users to add a particular threaded nut that fits onto the joystick nub. This update is inspired by design choices from Vulcan21 and the detailed installation steps validated with him personally.

This should be a viable improvement to the documentation for this enclosure model.

Up to date 5/9/23 merge
Adding explanation on optional comfort upgrade to Open Pill joystick by screwing a particular sized nut onto the end.
@SeedSigner
Copy link
Owner

Thank you for this thought. Maybe you could reformat this as a note at the bottom of the document? That final item in the list being a full paragraph seems to throw off the tidiness of the list format. Like:

  • Comfortable Controls? No (see note below)

This note would also apply to the Open Pill Mini enclosure, so it could make sense to duplicate it there.

Also, if we're going to display that image, we should keep a copy of the pic in our repo, appropriately named under:

seedsigner/docs/img

Please include the addition of this image in the PR. 👍

@bitcoinprecept
Copy link
Contributor Author

Thank you for the feedback. I've made the suggested edits and think it looks much better. The photo is stored in the proper place, and both open pill and open pill mini notes have been updated to include this information.

@newtonick
Copy link
Collaborator

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants