Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dire-warning detour if invalid BIP-85 child index #372

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

jdlcdl
Copy link

@jdlcdl jdlcdl commented May 22, 2023

resolves issue #369

This pr adds a detour to Dire Warning whenever a BIP-85 Child Index is outside the valid range of (0, 2**31-1), informing the user and forcing them to "Try Again", instead of the application crashing.

Related to this pr is #370 (handling exceptions which have no exception message), but they are independent of each other.

  • if this one is merged but not the other one: the bug reported in BIP85 child seed - index variable overflow #369 will be resolved, and the exception handler bug will be disguised until another message-less exception is found.
  • if the other one is merged but not this one: users would see a vague "Assertion Error" with embit references, and can start over... guessing what they did wrong... but at least the application won't crash.
  • if both are merged, users are informed and can try again AND we might learn of exception-type/filename/line-number the next time seedsigner "hangs" for message-less exceptions.

@newtonick
Copy link
Collaborator

ACK Tested

Copy link
Collaborator

@newtonick newtonick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@newtonick newtonick merged commit 9ef9b90 into SeedSigner:dev Jun 29, 2023
@jdlcdl jdlcdl deleted the limit_bip85_index branch July 16, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants