Message signing network mismatch bugfix; OptionDisabledView
bugfix
#443
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Message signing was already checking for "Network Mismatch" if a user was configured for MAINNET in Settings but scanned in a
signmessage
QR with a TESTNET/REGTEST derivation path specified.However, it was not checking the opposite: Settings configured for TESTNET or REGTEST but scan in a
signmessage
QR for MAINNET.Second bug: When message signing is disabled in Settings, the
OptionDisabledView
appears but then did not return any values, resulting in a second error screen.This PR:
signmessage
QR for MAINNET).test_sign_message_network_mismatch_flow
to test for all possible network mismatches and DRY-ifies it for internal reuse.OptionDisabledView
to jump straight to the relevant Settings update.ScanView
and intoSeedSignMessageStartView
OptionDisabledView
to screenshot generator.