Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Final word calc UI spacing fix; TextArea consistency/placement improvements #445

Merged
merged 5 commits into from
Aug 22, 2023

Conversation

kdmukai
Copy link
Contributor

@kdmukai kdmukai commented Aug 18, 2023

  • Fixes rendering on ToolsCalcFinalWordShowFinalWordView
  • Updates TextArea to be more internally consistent and easier to work with (with respect to text height and positioning). Now the Screen has full control over whether or not the TextArea includes pixels rendered below the baseline in its height/spacing calculations.
  • Light refactor in the Calc Final Word Views to move the actual final words calcs into ToolsCalcFinalWordShowFinalWordView in order to make that View independent (necessary in order to generate screenshots).
  • Adds screenshots for ToolsCalcFinalWordShowFinalWordView variations.
  • Improves screenshot generator's error reporting to aid in debugging failed screenshots.

ToolsCalcFinalWordShowFinalWordView_coin_flips   ToolsCalcFinalWordShowFinalWordView_pick_word

@jdlcdl
Copy link

jdlcdl commented Aug 19, 2023

As of commit 53e6205:

Tested the beaf4ae pre-release image and confirmed that text hung below the button,
and that this pr fixes that display as is represented in screenshots above.

@newtonick newtonick added this to the 0.7.0 milestone Aug 21, 2023
@newtonick newtonick added the bug Something isn't working label Aug 21, 2023
@newtonick
Copy link
Collaborator

ACK and Tested

@newtonick newtonick merged commit 8b5c8af into SeedSigner:dev Aug 22, 2023
@kdmukai kdmukai deleted the final_word_calc_screen_fix branch September 2, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

3 participants