Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Select Diff Seed bug that redirects to PSBTOverviewView #451

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

newtonick
Copy link
Collaborator

@newtonick newtonick commented Aug 23, 2023

Fixes Issue #449

Sign a PSBT that has already been signed with the same seed and you will see the PSBTSigningErrorView. However when you select "Select Diff Seed" you expect to be brought to PSBTSelectSeedView however PSBTSelectSeedView redirects to PSBTOverviewView because self.controller.psbt_seed has a value. This simple fix clears self.controller.psbt_seed prior to setting the next destination of PSBTSelectSeedView.

This also includes a unit test

@newtonick newtonick added this to the 0.7.0 milestone Aug 23, 2023
@jdlcdl
Copy link

jdlcdl commented Aug 23, 2023

As of commit 288512a,

ACK tested.

I was able to reproduce this with SeedSigner's help, using sparrow. I had my ideas about this fix but I was advancing way too slowly thru PSBT flow tests, to prove that this bug exists before attempting a fix. Thank you Nick for great progress last night.

I'll note that this fix is just one commit ahead of important bug-fix merges made last night. I would encourage testing/ACKing and merge of this fix sooner than later so that we can keep up to date as we approach release.

@newtonick newtonick merged commit 9d616a5 into SeedSigner:dev Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants