Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Additional edge padding for Warning Screen body text #461

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

kdmukai
Copy link
Contributor

@kdmukai kdmukai commented Aug 28, 2023

The problem

Current Warning Screens use the standard GUIConstants.EDGE_PADDING for the left and right limits for the body text. But the pulsing yellow or red warning edges fill that edge padding. Depending on the line breaks, text can potentially directly touch the pulsing warning edges.

The fix

Double the default edge padding for Warning Screens.


Before / After
(unfortunately we can't currently render the yellow/red warning edges, so just imagine the edges being filled in)

ErrorView-before ErrorView-after

This change affects all Warning Screens, so you must regenerate screenshots to see the changes.

PSBTNoChangeWarningView-before PSBTNoChangeWarningView-after


Additional changes

  • Adds a screenshot for the generic ErrorView
  • Pulls the more general errors out into their own section at the end of the screenshot generator output
  • Renames the example SettingsQR since "factory reset" terminology only makes sense for a retail product.

Follow-up steps

If merged, generate new screenshots and update https://github.com/SeedSigner/seedsigner-screenshots

@jdlcdl
Copy link

jdlcdl commented Aug 30, 2023

As of 0883c8e

ACK tested

I used an invalid qrcode and it was easy to see this improvement (SettingsQR via Seeds/ScanSeed).

@newtonick newtonick added the enhancement New feature or request label Sep 1, 2023
@newtonick
Copy link
Collaborator

ACK Tested

@newtonick newtonick merged commit e9fd26e into SeedSigner:dev Sep 1, 2023
@kdmukai kdmukai deleted the warning_screen_body_text_edges branch September 2, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants