-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing parentheses from assert statements #462
Removing parentheses from assert statements #462
Conversation
fyi, @conraddonovan16 github understands certain verbs related to issues: closes #459. When it sees that in the PR and the PR is merged, the Issue will also be auto-closed. see: https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests |
ACK tested.
|
At first glance, I'm not sure why pyzbar is new here. I thought it was indeed added to our environment, and that it will appear in our local repo depending how we install it, but not sure why it's in this pr, I suspect it was added by mistake.
|
as of 3011211 ACK tested |
Wow, that was a great catch @jdlcdl! When I review changes I don't pay much attention to the left-hand tree structure view. Totally missed that submodule inclusion. |
Actually, I breezed right by it. Halfway down I was thinking: "This is such a nice and tight pr, one line deleted, one line added, I just have to pay attention and it's going to be acked as soon as I reach the bottom." When I scrolled up, I noticed 41 added, 40 deleted, so I ran thru it again thinking I missed a newline. I was about to give up, then I saw it at the top. After speaking with Conrad, we both realized that |
ACK and Tested |
Removing the parentheses from assert statements according to issue #459
fixes #459