[bugfix] Prevent SettingsQR from trying to enable Persistent Settings when SD card is not inserted #464
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #457
The problem
If you remove the SD card and then scan in a SettingsQR that attempts to enable Persistent Settings, you get a System Error exception.
The fix
Additional changes
MicroSD
class so that individual tests can run scenarios with varyingMicroSD.is_inserted
states. Instead of the original class'is_inserted
property, we just provide it as an exposed class var that any test can directly alter as needed. The setup for each test automatically resets it to True (seeBaseTest.setup_method()
).SettingsUpdatedScreen
out of scan_screens.py and renamed into settings_screens.py.TestSettings
that omittedsuper().setup_class()
. Had no effect before, but runs into problems with the updates inBaseTest
in this PR without it.