[Bugfix] Xpub export can select the wrong coordinator #490
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How to reproduce the bug:
What is happening?
Multiselect options just pop or append to a list of available options. In this flow, BlueWallet is now at the end of the list.
But the coordinator selection View is assuming that the options are sorted the way they're defined in the SettingsEntry for that attribute (see:
SettingsConstants.ALL_COORDINATORS
).The fix
Use the SettingsEntry to retrieve the selected coordinator via
get_selection_option_value_by_display_name
which is completely independent of any ordering.This pull request is categorized as a:
Checklist
pytest
and made sure all unit tests pass before sumbitting the PRIf you modified or added functionality/workflow, did you add new unit tests?
Though this bug is sequence-dependent, I didn't think it merited a flow-based test since the ultimate problem was just that the View wasn't using the best technique to retrieve its selected value.
I have tested this PR on the following platforms/os:
Note: Keep your changes limited in scope; if you uncover other issues or improvements along the way, ideally submit those as a separate PR. The more complicated the PR the harder to review, test, and merge.