Skip to content

building source on Mac has one error... but succeeds. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TylerLeonhardt opened this issue Dec 29, 2017 · 2 comments · Fixed by #2
Closed

building source on Mac has one error... but succeeds. #1

TylerLeonhardt opened this issue Dec 29, 2017 · 2 comments · Fixed by #2

Comments

@TylerLeonhardt
Copy link

Here's the output of Invoke-Build:

Invoke-Build
Downloading dotnet version 2.1.2
Build . /Users/tylerleonhardt/Desktop/CompSci/DotNET/UnixConsoleEcho/UnixConsoleEcho.build.ps1
Task /./Build/Clean

Welcome to .NET Core!
---------------------
Learn more about .NET Core @ https://aka.ms/dotnet-docs. Use dotnet --help to see available commands or go to https://aka.ms/dotnet-cli-docs.

Telemetry
--------------
The .NET Core tools collect usage data in order to improve your experience. The data is anonymous and does not include command-line arguments. The data is collected by Microsoft and shared with the community.
You can opt out of telemetry by setting a DOTNET_CLI_TELEMETRY_OPTOUT environment variable to 1 using your favorite shell.
You can read more about .NET Core tools telemetry @ https://aka.ms/dotnet-cli-telemetry.

Configuring...
-------------------
A command is running to initially populate your local package cache, to improve restore speed and enable offline access. This command will take up to a minute to complete and will only happen once.
Decompressing 100% 5816 ms
Expanding 100% 12243 ms
Microsoft (R) Build Engine version 15.5.179.9764 for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.

Done /./Build/Clean 00:00:21.4399750
Task /./Build/BuildNative
/Users/tylerleonhardt/Desktop/CompSci/DotNET/UnixConsoleEcho/src/Native/Unix/disable_key_echo.cpp:20:23: error: use of undeclared identifier 'nullptr'
    assert(termios != nullptr);
                      ^
1 error generated.
Done /./Build/BuildNative 00:00:01.9985450
Task /./Build/BuildDll
Microsoft (R) Build Engine version 15.5.179.9764 for .NET Core
Copyright (C) Microsoft Corporation. All rights reserved.

  Restoring packages for /Users/tylerleonhardt/Desktop/CompSci/DotNET/UnixConsoleEcho/src/UnixConsoleEcho/UnixConsoleEcho.csproj...
  Generating MSBuild file /Users/tylerleonhardt/Desktop/CompSci/DotNET/UnixConsoleEcho/src/UnixConsoleEcho/obj/UnixConsoleEcho.csproj.nuget.g.props.
  Generating MSBuild file /Users/tylerleonhardt/Desktop/CompSci/DotNET/UnixConsoleEcho/src/UnixConsoleEcho/obj/UnixConsoleEcho.csproj.nuget.g.targets.
  Restore completed in 520.81 ms for /Users/tylerleonhardt/Desktop/CompSci/DotNET/UnixConsoleEcho/src/UnixConsoleEcho/UnixConsoleEcho.csproj.
  UnixConsoleEcho -> /Users/tylerleonhardt/Desktop/CompSci/DotNET/UnixConsoleEcho/src/UnixConsoleEcho/bin/Debug/netstandard1.1/UnixConsoleEcho.dll

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:01.88
Done /./Build/BuildDll 00:00:04.1374220
Done /./Build 00:00:27.6018100
Done /. 00:00:27.6104170
Build succeeded. 5 tasks, 0 errors, 0 warnings 00:00:49.9981540

You can see the error here:

/Users/tylerleonhardt/Desktop/CompSci/DotNET/UnixConsoleEcho/src/Native/Unix/disable_key_echo.cpp:20:23: error: use of undeclared identifier 'nullptr'
    assert(termios != nullptr);
                      ^
1 error generated.

This doesn't look ok, but maybe it is?

@TylerLeonhardt
Copy link
Author

@SeeminglyScience After adding -std=c++0x to the g++ line, it seems to have worked!

SeeminglyScience added a commit that referenced this issue Dec 30, 2017
This change fixes an issue where the build script would fail on MacOS
with an error referencing the nullptr keyword.

fixes #1
SeeminglyScience added a commit that referenced this issue Dec 30, 2017
This change fixes an issue where the build script would fail on MacOS
with an error referencing the nullptr keyword.

fixes #1
@SeeminglyScience
Copy link
Owner

@tylerl0706 Thanks man! Package is published, once indexing is finished I'll get the PSES PR up :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants