Skip to content

Commit

Permalink
feat(text api): add available_versions to the returned object.
Browse files Browse the repository at this point in the history
  • Loading branch information
YishaiGlasner committed Sep 13, 2023
1 parent 3114834 commit c69e1a9
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
4 changes: 2 additions & 2 deletions api/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@ def _handle_warnings(self, data):
elif vtitle and vtitle != 'all':
warning = APINoVersion(self.oref, vtitle, lang)
else:
warning = APINoLanguageVersion(self.oref, data['availabe_langs'])
warning = APINoLanguageVersion(self.oref, data['available_langs'])
representing_string = f'{lang}|{vtitle}' if vtitle else lang
data['warnings'].append({representing_string: warning.get_message()})
data.pop('missings')
data.pop('availabe_langs')
data.pop('available_langs')
return data

def get(self, request, *args, **kwargs):
Expand Down
6 changes: 5 additions & 1 deletion sefaria/model/text_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,14 @@ def __init__(self, oref: Ref, versions_params: List[List[str]]):
self.oref = oref
self.handled_version_params = []
self.all_versions = self.oref.versionset()

fields = Version.optional_attrs + Version.required_attrs
fields.remove('chapter') # not metadata
self.return_obj = {
'versions': [],
'missings': [],
'availabe_langs': sorted({v.actualLanguage for v in self.all_versions})
'available_langs': sorted({v.actualLanguage for v in self.all_versions}),
'available_versions': [{f: getattr(v, f, "") for f in fields} for v in self.all_versions]
}

def _append_version(self, version):
Expand Down

0 comments on commit c69e1a9

Please sign in to comment.