Skip to content

Commit

Permalink
bump varnamelen from v0.4.0 to v0.5.0 (golangci#2369)
Browse files Browse the repository at this point in the history
  • Loading branch information
blizzy78 authored and SeigeC committed Apr 4, 2023
1 parent 3d9f54b commit 0529659
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 4 deletions.
4 changes: 3 additions & 1 deletion .golangci.example.yml
Original file line number Diff line number Diff line change
Expand Up @@ -722,13 +722,15 @@ linters-settings:
ignore-names:
- err
# Optional list of variable declarations that should be ignored completely. (defaults to empty list)
# Entries must be in the form of "<variable name> <type>" or "<variable name> *<type>".
# Entries must be in the form of "<variable name> <type>" or "<variable name> *<type>" for
# variables, or "const <name>" for constants.
ignore-decls:
- c echo.Context
- t testing.T
- f *foo.Bar
- e error
- i int
- const C

whitespace:
multi-if: false # Enforces newlines (or comments) after every multi-line if statement
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ require (
github.com/ashanbrown/forbidigo v1.2.0
github.com/ashanbrown/makezero v0.0.0-20210520155254-b6261585ddde
github.com/bkielbasa/cyclop v1.2.0
github.com/blizzy78/varnamelen v0.4.0
github.com/blizzy78/varnamelen v0.5.0
github.com/bombsimon/wsl/v3 v3.3.0
github.com/breml/bidichk v0.2.1
github.com/butuzov/ireturn v0.1.1
Expand Down
2 changes: 2 additions & 0 deletions go.sum

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/golinters/gocritic.go
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ func configureCheckerInfo(
// Maybe in the future, this kind of conversion will be done in go-critic itself.
func normalizeCheckerParamsValue(lintCtx *linter.Context, p interface{}) interface{} {
rv := reflect.ValueOf(p)
//nolint:exhaustive // only 3 types (int, bool, and string) are supported by CheckerParam.Value
// nolint:exhaustive // only 3 types (int, bool, and string) are supported by CheckerParam.Value
switch rv.Type().Kind() {
case reflect.Int64, reflect.Int32, reflect.Int16, reflect.Int8, reflect.Int:
return int(rv.Int())
Expand Down
2 changes: 1 addition & 1 deletion pkg/golinters/godot.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ func NewGodot() *goanalysis.Linter {
}

// Convert deprecated setting
if cfg.CheckAll { // nolint: staticcheck
if cfg.CheckAll { // nolint:staticcheck
settings.Scope = godot.TopLevelScope
}

Expand Down

0 comments on commit 0529659

Please sign in to comment.