-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker setup #43
Docker setup #43
Conversation
@@ -107,7 +108,21 @@ async function saveToDatabase(encTile: any) { | |||
|
|||
socket.emit("saveToDatabaseResponse"); | |||
} | |||
|
|||
async function create_encrypted_tiles(){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
natural language paragraph comment above each function please. one or two sentences describing what + why is plenty
Dockerfile
Outdated
RUN sh docker_scripts/client_setup.sh | ||
|
||
# Run the application. | ||
#CMD ["pnpm", "-C", "client", "devA"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: no left over comments in main
compose.yaml
Outdated
db-data: | ||
driver: local | ||
common-contracts: | ||
driver: local |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: newline
docker_scripts/client_setup.sh
Outdated
|
||
cd client | ||
pnpm install | ||
cd .. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: newline
docker_scripts/contracts_run.sh
Outdated
foundryup | ||
|
||
|
||
pnpm -C contracts dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: newline
docker_scripts/contracts_setup.sh
Outdated
|
||
cd contracts | ||
pnpm build | ||
cd .. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: newline
docker_scripts/da_setup.sh
Outdated
|
||
cd DA | ||
pnpm install | ||
cd .. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: newline
README.md
Outdated
``` | ||
anvil | ||
``` | ||
|
||
### Compile circuit | ||
* Compile circuit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mind updating these instructions as well? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
No description provided.