Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker setup #43

Merged
merged 5 commits into from
Jan 9, 2024
Merged

Docker setup #43

merged 5 commits into from
Jan 9, 2024

Conversation

DarshanAgarwal09
Copy link
Contributor

No description provided.

@@ -107,7 +108,21 @@ async function saveToDatabase(encTile: any) {

socket.emit("saveToDatabaseResponse");
}

async function create_encrypted_tiles(){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

natural language paragraph comment above each function please. one or two sentences describing what + why is plenty

Dockerfile Outdated
RUN sh docker_scripts/client_setup.sh

# Run the application.
#CMD ["pnpm", "-C", "client", "devA"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: no left over comments in main

compose.yaml Outdated
db-data:
driver: local
common-contracts:
driver: local
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: newline


cd client
pnpm install
cd ..
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: newline

foundryup


pnpm -C contracts dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: newline


cd contracts
pnpm build
cd ..
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: newline


cd DA
pnpm install
cd ..
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: newline

README.md Outdated
```
anvil
```

### Compile circuit
* Compile circuit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mind updating these instructions as well? :)

Copy link
Contributor

@alex-lindenbaum alex-lindenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@alex-lindenbaum alex-lindenbaum merged commit 837367f into main Jan 9, 2024
@alex-lindenbaum alex-lindenbaum deleted the docker-setup branch January 9, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants