Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Default to ubuntu 22.04 with Python 3.12 #109

Merged
merged 8 commits into from
Feb 15, 2024
Merged

Conversation

JonZeolla
Copy link
Member

@JonZeolla JonZeolla commented Feb 13, 2024

Contributor Comments

Depends on #108 - needs a rebase after that merges.

Pull Request Checklist

Thank you for submitting a contribution to cookiecutter-python!

In order to streamline the review of your contribution we ask that you review and comply with the below requirements:

  • If you are adding a dependency, please explain how it was chosen.
  • If manual testing is needed in order to validate the changes, provide a testing plan and the expected results.
  • Validate that documentation is accurate and aligned to any project updates or additions.

Don't forget our more detailed contribution guidelines
here.

@JonZeolla JonZeolla requested review from a team and seanctech as code owners February 13, 2024 19:38
@JonZeolla JonZeolla added the blocked Unable to make progress label Feb 13, 2024
@JonZeolla JonZeolla changed the title feat: Default to ubuntu 22.04 feat: Default to ubuntu 22.04 with Python 3.12 Feb 13, 2024
@JonZeolla JonZeolla removed the blocked Unable to make progress label Feb 14, 2024
@JonZeolla
Copy link
Member Author

Something is up with the tests in the pipeline. Worked locally

seanctech
seanctech previously approved these changes Feb 14, 2024
Copy link
Member

@seanctech seanctech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JonZeolla JonZeolla enabled auto-merge (squash) February 15, 2024 20:34
@seanctech seanctech self-requested a review February 15, 2024 21:17
Copy link
Member

@seanctech seanctech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JonZeolla JonZeolla merged commit e90b1be into main Feb 15, 2024
3 checks passed
@JonZeolla JonZeolla deleted the make-22.04-default branch February 15, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants