Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove pipenv bug workaround #204

Merged
merged 1 commit into from
Oct 6, 2022
Merged

fix: Remove pipenv bug workaround #204

merged 1 commit into from
Oct 6, 2022

Conversation

JonZeolla
Copy link
Member

@JonZeolla JonZeolla commented Oct 5, 2022 •
edited
Loading

Contributor Comments

Removes the python 3.10.5 workaround for a bug fixed in pipenv 2022.10.04

Pull Request Checklist

Thank you for submitting a contribution to easy_infra!

In order to streamline the review of your contribution we ask that you review and comply with the below requirements:

  • Rebase your branch against the latest commit of the target branch
  • If you are adding a dependency, please explain how it was chosen
  • If manual testing is needed in order to validate the changes, provide a testing plan and the expected results
  • If there is an issue associated with your Pull Request, link the issue to the PR.

@JonZeolla JonZeolla requested a review from digeseiso October 5, 2022 12:14
@JonZeolla JonZeolla enabled auto-merge (squash) October 5, 2022 12:22
@JonZeolla JonZeolla merged commit b2dd9b8 into main Oct 6, 2022
@JonZeolla JonZeolla deleted the remove-pipenv-workaround branch October 6, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digeseiso digeseiso digeseiso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonZeolla @digeseiso