Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: double quoting loop when encountering invalid logs #226

Merged
merged 1 commit into from
Dec 6, 2022
Merged

fix: double quoting loop when encountering invalid logs #226

merged 1 commit into from
Dec 6, 2022

Conversation

JonZeolla
Copy link
Member

@JonZeolla JonZeolla commented Dec 6, 2022 •
edited
Loading

Contributor Comments

fix: double quoting loop when encountering invalid logs

Pull Request Checklist

Thank you for submitting a contribution to easy_infra!

In order to streamline the review of your contribution we ask that you review and comply with the below requirements:

  • Rebase your branch against the latest commit of the target branch
  • If you are adding a dependency, please explain how it was chosen
  • If manual testing is needed in order to validate the changes, provide a testing plan and the expected results
  • If there is an issue associated with your Pull Request, link the issue to the PR.

@JonZeolla JonZeolla requested a review from digeseiso December 6, 2022 03:03
@JonZeolla JonZeolla enabled auto-merge (squash) December 6, 2022 03:04
digeseiso
digeseiso approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@digeseiso digeseiso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic and syntax looks good to me

@JonZeolla JonZeolla merged commit 1e481d6 into main Dec 6, 2022
@JonZeolla JonZeolla deleted the fix-logging-failure-loop branch December 6, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digeseiso digeseiso digeseiso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonZeolla @digeseiso