Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update KICS #228

Merged
merged 8 commits into from
Dec 14, 2022
Merged

Update KICS #228

merged 8 commits into from
Dec 14, 2022

Conversation

JonZeolla
Copy link
Member

Contributor Comments

This moves to using the upstream KICS docker images from docker hub at build time. This is a workaround due to KICS no longer releasing binaries. See Checkmarx/kics#4744 and https://github.com/Checkmarx/kics/releases/tag/v1.5.1

Pull Request Checklist

Thank you for submitting a contribution to easy_infra!

In order to streamline the review of your contribution we ask that you review and comply with the below requirements:

  • Rebase your branch against the latest commit of the target branch
  • If you are adding a dependency, please explain how it was chosen
  • If manual testing is needed in order to validate the changes, provide a testing plan and the expected results
  • If there is an issue associated with your Pull Request, link the issue to the PR.

JonZeolla
JonZeolla commented Dec 13, 2022
View reviewed changes
Copy link
Member Author

@JonZeolla JonZeolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYIs for the reviewer

build/Dockerfile.j2 Show resolved Hide resolved
easy_infra.yml Show resolved Hide resolved
tasks.py Show resolved Hide resolved
tasks.py Show resolved Hide resolved
tests/test.py Show resolved Hide resolved
build/Dockerfrag.kics Show resolved Hide resolved
build/Dockerfile.j2 Show resolved Hide resolved
@JonZeolla JonZeolla requested a review from digeseiso December 13, 2022 20:35
@JonZeolla JonZeolla changed the title Use upstream KICS docker images Update KICS Dec 13, 2022
@JonZeolla JonZeolla enabled auto-merge (squash) December 13, 2022 20:38
@JonZeolla JonZeolla merged commit 59cc34e into main Dec 14, 2022
@JonZeolla JonZeolla deleted the update-kics branch December 14, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digeseiso digeseiso digeseiso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonZeolla @digeseiso