Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add scan functions #229

Merged
merged 14 commits into from
Jan 4, 2023
Merged

feat: Add scan functions #229

merged 14 commits into from
Jan 4, 2023

Conversation

JonZeolla
Copy link
Member

@JonZeolla JonZeolla commented Dec 21, 2022

Contributor Comments

This adds a special scan_{package} function that runs the related security scans but requires no arguments or command meaning it would be very useful for things like GitHub actions or bitbucket pipes.

Pull Request Checklist

Thank you for submitting a contribution to easy_infra!

In order to streamline the review of your contribution we ask that you review and comply with the below requirements:

  • Rebase your branch against the latest commit of the target branch
  • If you are adding a dependency, please explain how it was chosen
  • If manual testing is needed in order to validate the changes, provide a testing plan and the expected results
  • If there is an issue associated with your Pull Request, link the issue to the PR.

@JonZeolla JonZeolla marked this pull request as draft December 21, 2022 17:05
@JonZeolla JonZeolla requested a review from digeseiso December 21, 2022 21:42
@JonZeolla JonZeolla marked this pull request as ready for review December 21, 2022 21:42
@JonZeolla JonZeolla enabled auto-merge (squash) December 21, 2022 21:42
Copy link
Contributor

@ChiefHolland ChiefHolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a much cleaner way to build conditional logic into the for loops.

@JonZeolla JonZeolla merged commit 238ba4f into main Jan 4, 2023
@JonZeolla JonZeolla deleted the add-scan-command branch January 4, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants