Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: kics report path #305

Merged
merged 1 commit into from
Oct 26, 2023
Merged

fix: kics report path #305

merged 1 commit into from
Oct 26, 2023

Conversation

JonZeolla
Copy link
Member

@JonZeolla JonZeolla commented Oct 26, 2023

Contributor Comments

This fixes an incorrect variable uses to define the output directory to put KICS scan results in. We are using KICS_PATH but it should be KICS_JSON_REPORT_PATH. This seems to be a very long-lived copy/paste mistake, dating back to at least August 2021 via e5803e1.

Pull Request Checklist

Thank you for submitting a contribution to our project!

In order to streamline the review of your contribution we ask that you review and comply with the below requirements:

  • Rebase your branch against the latest commit of the target branch.
  • If you are adding a dependency, please explain how it was chosen.
  • If manual testing is needed in order to validate the changes, provide a testing plan and the expected results.
  • If there is an issue associated with your Pull Request, link the issue to the PR.
  • Validate that documentation is accurate and aligned to any project updates or additions.

Don't forget our more detailed contribution guidelines
here.

@JonZeolla JonZeolla enabled auto-merge (squash) October 26, 2023 17:10
Copy link
Contributor

@ChiefHolland ChiefHolland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JonZeolla JonZeolla merged commit bfa8bcb into main Oct 26, 2023
19 checks passed
@JonZeolla JonZeolla deleted the fix-kics-report-path branch October 26, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants