Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visibility to constants #1228

Merged
merged 1 commit into from
Nov 29, 2018

Conversation

gmponos
Copy link
Contributor

@gmponos gmponos commented Nov 17, 2018

PSR-12 Just for reference if it gets accepted:

Visibility MUST be declared on all constants if your project PHP minimum version supports constant visibilities (PHP 7.1 or later).

Personally I like it also this way better. Maybe you should revise some of them if they should be public but this would be a BC. Since you are moving to v2.0 it's a good chance.

@Seldaek Seldaek added this to the 2.0 milestone Nov 19, 2018
@Seldaek
Copy link
Owner

Seldaek commented Nov 29, 2018

Thanks, adjusted visibilities in bb99e4c

@Seldaek Seldaek merged commit c68b71e into Seldaek:master Nov 29, 2018
Seldaek added a commit that referenced this pull request Nov 29, 2018
@gmponos gmponos deleted the add_visibility_to_constants branch November 29, 2018 20:43
@lyrixx lyrixx mentioned this pull request Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants