Add AsMonologProcessor attribute #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
commented
Feb 24, 2022
| * needed and manually pushed to the loggers and to the processable handlers. | ||
| */ | ||
| #[\Attribute(\Attribute::TARGET_CLASS | \Attribute::TARGET_METHOD | \Attribute::IS_REPEATABLE)] | ||
| class AsMonologProcessor |
There was a problem hiding this comment.
Having Monolog in the name is good from an external POV I think. In a project, it gives more information than just AsProcessor.
| class AsMonologProcessor | ||
| { | ||
| /** | ||
| * @param string|null $channel The logging channel the processor should be pushed to. |
There was a problem hiding this comment.
In symfony/monolog-bundle, setting both channel and handler will throw. Also setting method if the attribute is used as the method level will throw. Also, the method falls back to __invoke.
I didn't add any hints about this here because I guess it's just easier to accept everything and let each implementation do what they want.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref symfony/monolog-bundle#428
This PR adds an attribute that third-party consumers can leverage to "configure" Monolog processors.
I didn't find any real benefits in supporting it directly in Monolog's
pushProcessor()methods:callabletocallable|objectto accept any objects potentially using the attribute, and that would be a BC break.method"option" and it doesn't bring any real value, it's already easy to do:cc @derrabus and @nicolas-grekas