-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
finishing Syslog formatter #1689
Conversation
@picass0 thanks so much for working on this! \o/ I'm not picky about structured data being in the message TBH. My only worry is if lnav will be able to use it to filter the messages? Being able to have it running in development with my Symfony apps is basically the only reason why I'd want this formatter. Could you test your implementation with it to confirm it will work? If so, I'm all 👍 here. |
Thanks for response @dkarlovi ) simplescreenrecorder-2022-06-17_01.05.44.mp4 |
Thank you both! |
Just FYI f7dfa00 reverts some changes done here to keep BC and make use of the new Level::toRFC5424Level method - hope that makes sense to you too. |
Sorry for breaking BC. I think u missed one use statement here \Monolog\Formatter\SyslogFormatter:14 |
Right, cleaned those up :) And no worries about the BC break, it was very minor so I thought I'd let it slide but then I realized I could as well just fix it easily. |
This PR finishes work started by @dkarlovi here #1599
In theory metadata(context and extra) can be stored in native syslog structured data format https://datatracker.ietf.org/doc/html/rfc5424#section-6.3 (as suggested by @dkarlovi) but storing arbitrary structred data requires registering "private enterprise number" with IANA(it says so in here https://datatracker.ietf.org/doc/html/rfc5424#section-6.3.2) which looks like too much work, so i just added metadata as part of a message. Hope this is ok