Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kernel function extension #558
base: master
Are you sure you want to change the base?
Kernel function extension #558
Changes from 9 commits
b9043fd
b5f48c5
27be93b
e05ee05
753ba72
8832bef
d53984f
657e7b8
8322330
0199bac
3d235fb
4587499
bd1dde9
52486da
d6af592
43b0b4c
335fe2c
d059f65
a843973
50197ab
db824e8
d8c8083
3de8f98
0f63f61
e9e9874
61032e0
82d9dd4
7e64b57
1084180
8af1c51
bdad9d3
bca489b
be7d9fa
6cc1798
1e381f4
b14db5a
b24655e
fb922a2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mauicv @ascillitoe I feel like this is confusing for typing purposes and somehow unnecessarily indicates coupling between kernel interfaces and backends. Feel like there should be a top-level class that is backend-agnostic for typing purposes, perhaps a
Protocol
is valid, although not if we have to rely on inheriting fromBaseKernel
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My initial idea for simplifying serialisation and perhaps the optional deps stuff was to look at backend-agnostic parent classes for kernels and even preprocessing (i.e. replace the combination of
preprocess_drift
andpartial
with a preprocessing class). These backend-agnostic classes would haveget_config
andfrom_config
methods, and also do the dispatching to the relevant backend-specific classes. That being said I didn't get around to doing any sort of POC so it might be a non-starter... Doing something similar but only for typing, via aProtocol
, sounds like an interesting one...