Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.7 #825

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Drop Python 3.7 #825

merged 1 commit into from
Jul 7, 2023

Conversation

ascillitoe
Copy link
Contributor

Dropping Python 3.7 since it has been EoL since June 27th: https://endoflife.date/python

@ascillitoe ascillitoe requested a review from mauicv July 6, 2023 14:36
@ascillitoe
Copy link
Contributor Author

Following to be updated in a separate PR (inc. notebook CI's):

- os: windows-latest
python-version: '3.9' # PyTorch doesn't yet have 3.10 support on Windows (https://pytorch.org/get-started/locally/#windows-python)
- os: macos-latest
python-version: '3.9' # Don't test python3.10 for macos (see https://github.com/orgs/community/discussions/38364 for details)

@ascillitoe
Copy link
Contributor Author

@mauicv same here, I think we can merge despite ci failing?

Copy link
Collaborator

@mauicv mauicv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ascillitoe ascillitoe merged commit 74d20eb into SeldonIO:master Jul 7, 2023
@ascillitoe ascillitoe deleted the feature/drop_3.7 branch July 7, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants