Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notebooks tests for 3.11 (#840) #841

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Conversation

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #841 (1d761a5) into master (c580354) will not change coverage.
The diff coverage is n/a.

❗ Current head 1d761a5 differs from pull request most recent head 6e870c2. Consider uploading reports for the commit 6e870c2 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #841   +/-   ##
=======================================
  Coverage   81.89%   81.89%           
=======================================
  Files         159      159           
  Lines       10332    10332           
=======================================
  Hits         8461     8461           
  Misses       1871     1871           

@jklaise
Copy link
Contributor Author

jklaise commented Jul 17, 2023

Similar to #839 - only test on 3.10 for Windows/MacOS due to torch 1.x requirement.

Copy link
Contributor

@ascillitoe ascillitoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jklaise
Copy link
Contributor Author

jklaise commented Jul 18, 2023

Didn't rebase against master (#842) hence the notebook failures. Will merge and trigger tests for #824.

@jklaise jklaise merged commit 8219ec3 into master Jul 18, 2023
10 of 22 checks passed
@jklaise jklaise deleted the dev/test-notebooks-3.11 branch July 18, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants