Skip to content

Commit

Permalink
Update helm example and charts
Browse files Browse the repository at this point in the history
  • Loading branch information
ukclivecox committed Oct 7, 2018
1 parent 18f393a commit 042fb72
Show file tree
Hide file tree
Showing 14 changed files with 3,004 additions and 1,345 deletions.
5 changes: 0 additions & 5 deletions docs/getting_started/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,4 @@ You can use ```kubectl``` to deploy your ML service like any other Kubernetes re
# Next Steps

* [Jupyter notebooks showing worked examples](../../readme.md#quick-start)
* Templated Helm Charts:
* [Single Model with optional Outlier Detector](https://github.com/SeldonIO/seldon-core/tree/master/helm-charts/seldon-single-model)
* [AB Test between two models](https://github.com/SeldonIO/seldon-core/tree/master/helm-charts/seldon-abtest)
* [Multi-Armed Bandit of two models](https://github.com/SeldonIO/seldon-core/tree/master/helm-charts/seldon-mab)
* [Integration with other machine learning frameworks](../../readme.md#integrations)

5 changes: 5 additions & 0 deletions docs/install.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,3 +78,8 @@ Notes

* [Install Seldon as part of Kubeflow.](https://www.kubeflow.org/docs/guides/components/seldon/#seldon-serving)
* Kubeflow presently runs 0.1 version of seldon-core. This will be updated to 0.2 in the near future.


# Next Steps

* [Jupyter notebooks showing worked examples](../readme.md#quick-start)
6 changes: 3 additions & 3 deletions helm-charts/seldon-abtest/templates/ab_test_1pod.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@
"labels": {
"app": "seldon"
},
"name": "seldon-deployment-example"
"name": "{{ .Release.Name }}"
},
"spec": {
"name": "{{ .Values.name }}",
"name": "{{ .Release.Name }}",
{{- if .Values.oauth.key }}
"oauth_key": "{{ .Values.oauth.key }}",
"oauth_secret": "{{ .Values.oauth.secret }}",
Expand Down Expand Up @@ -46,7 +46,7 @@
}
}],
"graph": {
"name": "random-ab-test",
"name": "{{ .Release.Name }}",
"endpoint":{},
"implementation":"RANDOM_ABTEST",
"parameters": [
Expand Down
6 changes: 3 additions & 3 deletions helm-charts/seldon-abtest/templates/ab_test_2pods.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@
"labels": {
"app": "seldon"
},
"name": "seldon-deployment"
"name": "{{ .Release.Name }}"
},
"spec": {
"name": "{{ .Values.name }}",
"name": "{{ .Release.Name }}",
{{- if .Values.oauth.key }}
"oauth_key": "{{ .Values.oauth.key }}",
"oauth_secret": "{{ .Values.oauth.secret }}",
Expand Down Expand Up @@ -56,7 +56,7 @@
}
}],
"graph": {
"name": "random-ab-test",
"name": "{{ .Release.Name }}",
"endpoint":{},
"implementation":"RANDOM_ABTEST",
"parameters": [
Expand Down
1 change: 0 additions & 1 deletion helm-charts/seldon-abtest/values.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
separate_pods: true
name: my-abtest
modela:
image:
name: seldonio/mock_classifier:1.0
Expand Down
4 changes: 2 additions & 2 deletions helm-charts/seldon-mab/templates/mab.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
"labels": {
"app": "seldon"
},
"name": "seldon-deployment"
"name": "{{ .Release.Name }}"
},
"spec": {
"name": "{{ .Values.name }}",
"name": "{{ .Release.Name }}",
{{- if .Values.oauth.key }}
"oauth_key": "{{ .Values.oauth.key }}",
"oauth_secret": "{{ .Values.oauth.secret }}",
Expand Down
1 change: 0 additions & 1 deletion helm-charts/seldon-mab/values.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
name: my-mab
modela:
image:
name: seldonio/mock_classifier:1.0
Expand Down
6 changes: 3 additions & 3 deletions helm-charts/seldon-single-model/templates/model.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
"labels": {
"app": "seldon"
},
"name": "seldon-model"
"name": "{{ .Release.Name }}"
},
"spec": {
"name": "test-deployment",
"name": "{{ .Release.Name }}",
{{- if .Values.oauth.key }}
"oauth_key": "{{ .Values.oauth.key }}",
"oauth_secret": "{{ .Values.oauth.secret }}",
Expand Down Expand Up @@ -80,7 +80,7 @@
{{- if .Values.outlier_detection.enabled }}
]}
{{- end }},
"name": "{{ .Values.name }}",
"name": "{{ .Release.Name }}",
"replicas": {{ .Values.replicas }},
"labels": {
"version" : "v1"
Expand Down
2 changes: 1 addition & 1 deletion helm-charts/seldon-single-model/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ model:
outlier_detection:
enabled: false
image:
name: seldonio/outlier_mahalanobis:0.2
name: seldonio/outlier_mahalanobis:0.3
n_components: 2
name: outlier-detector
replicas: 1
Expand Down
Loading

0 comments on commit 042fb72

Please sign in to comment.