Merge pull request #273 from cliveseldon/crd_status_2

Update when status is set
SeldonIO · Oct 30, 2018 · 27691f5 · 27691f5
2 parents 96d33a1 + 138626c
commit 27691f5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/...er-manager/src/main/java/io/seldon/clustermanager/k8s/SeldonDeploymentControllerImpl.java b/...er-manager/src/main/java/io/seldon/clustermanager/k8s/SeldonDeploymentControllerImpl.java
@@ -284,7 +284,7 @@ public void createOrReplaceSeldonDeployment(SeldonDeployment mlDep) {
 		        //removeServices(client,namespace, mlDep2, resources.services); //Proto Client not presently working for deletion
 		        ApiClient client2 = clientProvider.getClient();
 		        removeServices(client2,namespace, mlDep2, resources.services);
-		        if (!mlDep.getSpec().equals(mlDepStatusUpdated.getSpec()))
+		        if (existing == null || !mlDep.getSpec().equals(mlDepStatusUpdated.getSpec()))
 		        {
 		           logger.debug("Pushing updated SeldonDeployment "+mlDepStatusUpdated.getMetadata().getName()+" back to kubectl");
 		           crdHandler.updateSeldonDeploymentStatus(mlDepStatusUpdated);

diff --git a/...-manager/src/main/java/io/seldon/clustermanager/k8s/SeldonDeploymentStatusUpdateImpl.java b/...-manager/src/main/java/io/seldon/clustermanager/k8s/SeldonDeploymentStatusUpdateImpl.java
@@ -87,6 +87,10 @@ public void updateStatus(String mlDepName, String depName, Integer replicas, Int
                {
             	   mlBuilder.getStatusBuilder().setState(Constants.STATE_AVAILABLE);
                }
+               else
+               {
+            	   mlBuilder.getStatusBuilder().setState(Constants.STATE_CREATING);
+               }
                crdHandler.updateSeldonDeploymentStatus(mlBuilder.build());
             }
             else
-Original file line number
+Diff line change
@@ Expand Up @@
                    {
                 	   mlBuilder.getStatusBuilder().setState(Constants.STATE_AVAILABLE);
                    }
+                   else
+                   {
+                	   mlBuilder.getStatusBuilder().setState(Constants.STATE_CREATING);
+                   }
                    crdHandler.updateSeldonDeploymentStatus(mlBuilder.build());
                 }
                 else
@@ Expand Down @@