Added docstring; more verbose function name

executor/api/rest/middlewares.go

@@ -47,7 +47,10 @@ func (h *CloudeventHeaderMiddleware) Middleware(next http.Handler) http.Handler
 	})
 }
 
-func corsHeaders(next http.Handler) http.Handler {
+// handleCORSRequests adds CORS-required headers, and during CORS Preflight
+// requests, it will exit the request and the request status will be
+// http.StatusOK
+func handleCORSRequests(next http.Handler) http.Handler {
 	return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		w.Header().Set(corsAllowOriginHeader, corsAllowOriginValue)
 		w.Header().Set(corsAllowMethodsHeader, corsAllowMethodsValue)

executor/api/rest/middlewares_test.go

@@ -8,7 +8,7 @@ import (
 	. "github.com/onsi/gomega"
 )
 
-func TestCORSHeadersGet(t *testing.T) {
+func TestCORSHeadersGetRequest(t *testing.T) {
 	g := NewGomegaWithT(t)
 
 	m := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {})
@@ -31,7 +31,7 @@ func TestCORSHeadersGet(t *testing.T) {
 	g.Expect(headerValAllowMethods).To(Equal(corsAllowMethodsValue))
 }
 
-func TestCORSHeadersOptions(t *testing.T) {
+func TestCORSHeadersOptionsRequest(t *testing.T) {
 	g := NewGomegaWithT(t)
 
 	m := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {})

executor/api/rest/server.go

@@ -127,7 +127,7 @@ func (r *SeldonRestApi) Initialise() {
 		r.Router.Use(puidHeader)
 		r.Router.Use(cloudeventHeaderMiddleware.Middleware)
 		r.Router.Use(xssMiddleware)
-		r.Router.Use(corsHeaders)
+		r.Router.Use(handleCORSRequests)
 
 		switch r.Protocol {
 		case api.ProtocolSeldon: