Merge pull request #2054 from RafalSkolasinski/helm-charts/extend-sel…

…don-single-model extend seldon-single-model chart
SeldonIO · Jul 7, 2020 · 56cf87a · 56cf87a
2 parents 96cf61b + ea32181
commit 56cf87a
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 0 deletions.
diff --git a/helm-charts/seldon-single-model/README.md b/helm-charts/seldon-single-model/README.md
@@ -44,7 +44,9 @@ helm install $MY_MODEL_NAME seldonio/seldon-single-model --namespace $MODELS_NAM
 | labels | object | `{}` | Labels applied to the deployment |
 | model.env | object | `{"LOG_LEVEL":"INFO"}` | Environment variables injected into the model's container |
 | model.image | string | `""` | Docker image used by the model |
+| model.implementation | string | `""` | Implementation of Prepackaged Model Server |
 | model.logger.enabled | bool | `false` |  |
 | model.logger.url | string | `""` |  |
 | model.resources | object | `{"requests":{"memory":"1Mi"}}` | Resource requests and limits for the model's container |
+| model.uri | string | `""` | Model's URI for prepackaged model server |
 | replicas | int | `1` | Number of replicas for the predictor |
diff --git a/helm-charts/seldon-single-model/templates/seldondeployment.json b/helm-charts/seldon-single-model/templates/seldondeployment.json
@@ -22,6 +22,12 @@
         "name": "default",
         "graph": {
           "name": "model",
+          {{- if .Values.model.implementation }}
+          "implementation": "{{ .Values.model.implementation }}",
+          {{- end}}
+          {{- if .Values.model.uri }}
+          "modelUri": "{{ .Values.model.uri }}",
+          {{- end}}
           "type": "MODEL",
           {{- if .Values.model.logger.enabled }}
           "logger": {
@@ -38,7 +44,9 @@
               "containers": [
                 {
                   "name": "model",
+                  {{- if .Values.model.image }}
                   "image": "{{ .Values.model.image }}",
+                  {{- end}}
                   "env": [
                     {{- range $var, $val := .Values.model.env }}
                       {

diff --git a/helm-charts/seldon-single-model/values.yaml b/helm-charts/seldon-single-model/values.yaml
@@ -2,6 +2,10 @@
 apiVersion: machinelearning.seldon.io/v1
 
 model:
+  # model.implementation -- Implementation of Prepackaged Model Server
+  implementation: ""
+  # model.uri -- Model's URI for prepackaged model server
+  uri: ""
   # model.image -- Docker image used by the model
   image: ""
   # model.env -- Environment variables injected into the model's container