Skip to content

Commit

Permalink
Updated proto to correct component
Browse files Browse the repository at this point in the history
  • Loading branch information
axsaucedo committed Jul 12, 2021
1 parent fc26b8c commit 86f7d6e
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions python/seldon_core/seldon_methods.py
Original file line number Diff line number Diff line change
Expand Up @@ -179,9 +179,6 @@ def send_feedback(
-------
"""
is_proto = isinstance(request, prediction_pb2.Feedback)
seldon_metrics.update_reward(request.reward)

if hasattr(user_model, "send_feedback_rest"):
logger.warning("send_feedback_rest is deprecated. Please use send_feedback_raw")
request_json = json_format.MessageToJson(request)
Expand All @@ -196,7 +193,7 @@ def send_feedback(
try:
response = user_model.send_feedback_raw(request)
handle_raw_custom_metrics(
response, seldon_metrics, is_proto, FEEDBACK_METRIC_METHOD_TAG
response, seldon_metrics, True, FEEDBACK_METRIC_METHOD_TAG
)
return response
except SeldonNotImplementedError:
Expand Down

0 comments on commit 86f7d6e

Please sign in to comment.