Add missing rbac to helm flag to allow create

SeldonIO · Jun 19, 2020 · d8fff2c · d8fff2c
1 parent f890e8b
commit d8fff2c
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 0 deletions.
diff --git a/helm-charts/seldon-core-operator/templates/role_seldon-leader-election-role.yaml b/helm-charts/seldon-core-operator/templates/role_seldon-leader-election-role.yaml
@@ -1,3 +1,4 @@
+{{- if .Values.rbac.create }}
 apiVersion: rbac.authorization.k8s.io/v1
 kind: Role
 metadata:
@@ -35,3 +36,4 @@ rules:
   - events
   verbs:
   - create
+{{- end }}
diff --git a/...charts/seldon-core-operator/templates/rolebinding_seldon-leader-election-rolebinding.yaml b/...charts/seldon-core-operator/templates/rolebinding_seldon-leader-election-rolebinding.yaml
@@ -1,3 +1,4 @@
+{{- if .Values.rbac.create }}
 apiVersion: rbac.authorization.k8s.io/v1
 kind: RoleBinding
 metadata:
@@ -16,3 +17,4 @@ subjects:
 - kind: ServiceAccount
   name: seldon-manager
   namespace: '{{ .Release.Namespace }}'
+{{- end }}
diff --git a/operator/helm/split_resources.py b/operator/helm/split_resources.py
@@ -347,6 +347,15 @@ def helm_release(value: str):
                     + HELM_IF_END
                     + HELM_IF_END
                 )
+            elif (
+                name == "seldon-leader-election-rolebinding"
+                or name == "seldon-leader-election-role"
+                ):
+                fdata = (
+                        HELM_RBAC_IF_START
+                        + fdata
+                        + HELM_IF_END
+                )
             elif name == "seldon-manager" and kind == "serviceaccount":
                 fdata = HELM_SA_IF_START + fdata + HELM_IF_END
             elif kind == "issuer" or kind == "certificate":