Added guard for fedeback to only be sent for seldon protocol

SeldonIO · Nov 23, 2020 · dbc4591 · dbc4591
1 parent a83445d
commit dbc4591
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/executor/api/rest/client.go b/executor/api/rest/client.go
@@ -340,5 +340,9 @@ func (smc *JSONRestClient) TransformOutput(ctx context.Context, modelName string
 }
 
 func (smc *JSONRestClient) Feedback(ctx context.Context, modelName string, host string, port int32, req payload.SeldonPayload, meta map[string][]string) (payload.SeldonPayload, error) {
+	// Currently feedback is enabled across all protocols but client only works on seldon protocol
+	if smc.Protocol != api.ProtocolSeldon {
+		return req, nil
+	}
 	return smc.call(ctx, modelName, smc.modifyMethod(client.SeldonFeedbackPath, modelName), host, port, req, meta)
 }