Skip to content

Commit

Permalink
try allowing unknown istio fields
Browse files Browse the repository at this point in the history
  • Loading branch information
ryandawsonuk authored and seldondev committed Aug 12, 2020
1 parent a66ab89 commit e7f4c76
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions operator/controllers/seldondeployment_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,13 @@ type httpGrpcPorts struct {
grpcPort int
}

func init() {
// Allow unknown fields in Istio API client. This is so that we are more resilience
// in cases user clusers have malformed resources.
istio_networking.VirtualServiceUnmarshaler.AllowUnknownFields = true
istio_networking.GatewayUnmarshaler.AllowUnknownFields = true
}

func createAddressableResource(mlDep *machinelearningv1.SeldonDeployment, namespace string) (*machinelearningv1.SeldonAddressable, error) {
// It was an explicit design decision to expose the service name instead of the ingress
// Currently there will only be a URL for the first predictor, and assumes always REST
Expand Down

0 comments on commit e7f4c76

Please sign in to comment.