Add validation for empty pipeline steps (#607)

* Add error type for pipelines without steps defined * Add pipeline validation for empty steps in scheduler * Fix typo referencing wrong data in error
SeldonIO · Nov 22, 2022 · f5bd3f9 · f5bd3f9
1 parent 2ad5765
commit f5bd3f9
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/scheduler/pkg/store/pipeline/errors.go b/scheduler/pkg/store/pipeline/errors.go
@@ -100,6 +100,14 @@ func (pvm *PipelineVersionUidMismatchErr) Error() string {
 	return fmt.Sprintf("pipeline version uid mismatch %s:%d expected %s found %s", pvm.pipeline, pvm.version, pvm.uidExpected, pvm.uidActual)
 }
 
+type PipelineStepsEmptyErr struct {
+	pipeline string
+}
+
+func (psee *PipelineStepsEmptyErr) Error() string {
+	return fmt.Sprintf("pipeline %s has no steps defined", psee.pipeline)
+}
+
 type PipelineStepNotFoundErr struct {
 	pipeline string
 	step     string

diff --git a/scheduler/pkg/store/pipeline/validate.go b/scheduler/pkg/store/pipeline/validate.go
@@ -33,6 +33,9 @@ const (
 )
 
 func validate(pv *PipelineVersion) error {
+	if err := checkStepsExist(pv); err != nil {
+		return err
+	}
 	if err := checkStepNameNotPipelineName(pv); err != nil {
 		return err
 	}
@@ -57,6 +60,13 @@ func validate(pv *PipelineVersion) error {
 	return nil
 }
 
+func checkStepsExist(pv *PipelineVersion) error {
+	if len(pv.Steps) == 0 {
+		return &PipelineStepsEmptyErr{pipeline: pv.Name}
+	}
+	return nil
+}
+
 func checkStepNameNotPipelineName(pv *PipelineVersion) error {
 	for _, v := range pv.Steps {
 		if v.Name == pv.Name {