Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tox tests fail if py37 is not present #1247

Closed
adriangonz opened this issue Dec 12, 2019 · 2 comments · Fixed by #1433
Closed

Tox tests fail if py37 is not present #1247

adriangonz opened this issue Dec 12, 2019 · 2 comments · Fixed by #1433
Assignees
Labels
Milestone

Comments

@adriangonz
Copy link
Contributor

tox is configured to run the tests on a py37 environment. However, if Python 3.7 is not present the tests fail.

It seems that tox doesn't do anything besides checking if there is a python3.7 interpreter present. We should either change tox's config to run the tests on whatever environment is present or add some way for tox to fetch the relevant versions if they are not present.

@adriangonz adriangonz added bug triage Needs to be triaged and prioritised accordingly labels Dec 12, 2019
@axsaucedo axsaucedo added this to the 1.1 milestone Jan 16, 2020
@axsaucedo
Copy link
Contributor

@adriangonz is this something we want for 1.1 or push for later?

@adriangonz
Copy link
Contributor Author

@adriangonz I think it would be good to have a look for 1.1. I can have a look into it and while I'm there I can also add tests for Python 3.8.

@adriangonz adriangonz self-assigned this Jan 16, 2020
@adriangonz adriangonz removed the triage Needs to be triaged and prioritised accordingly label Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants