Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't specify version in Tox #1433

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Conversation

adriangonz
Copy link
Contributor

Fixes #1247

Changelog

  • Run tox with whatever Python version is present

@seldondev
Copy link
Collaborator

Thu Feb 13 10:35:23 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1433/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1433 --build=1

@seldondev
Copy link
Collaborator

Thu Feb 13 10:35:30 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1433/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1433 --build=2

@adriangonz
Copy link
Contributor Author

/cc @cliveseldon @RafalSkolasinski

@cliveseldon this should fix the Python tests whenever py37 is not present (e.g. because py36 is installed).

@RafalSkolasinski to run the tests across multiple versions we could add more versions to the envlist in the setup.cfg file and then install them as well on the seldonio/python-builder image. We could explore this for #1357.

@ukclivecox
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit 54699c9 into SeldonIO:master Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tox tests fail if py37 is not present
3 participants