Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiplex HTTP and gRPC on the executor #1762

Closed
glindsell opened this issue Apr 29, 2020 · 2 comments · Fixed by #1772
Closed

Multiplex HTTP and gRPC on the executor #1762

glindsell opened this issue Apr 29, 2020 · 2 comments · Fixed by #1772
Assignees
Milestone

Comments

@glindsell
Copy link
Contributor

glindsell commented Apr 29, 2020

This issue makes a start on #1628

This package https://github.com/soheilhy/cmux looks like it's allows multiplexing of the type that we need for this issue in the executor. Changes may need to be made to the operator too.

@glindsell glindsell added the triage Needs to be triaged and prioritised accordingly label Apr 29, 2020
@glindsell glindsell self-assigned this Apr 29, 2020
@ukclivecox ukclivecox removed the triage Needs to be triaged and prioritised accordingly label Apr 30, 2020
@ukclivecox ukclivecox added this to the 1.2 milestone Apr 30, 2020
@glindsell
Copy link
Contributor Author

WIP: #1772

@glindsell
Copy link
Contributor Author

glindsell commented May 13, 2020

Executor now takes a single --port flag.

Minimal changes have been made to the Operator to allow for the Executor to multiplex on the port supplied.

This functionality does not provide multiplexing from the viewpoint of the Operator - more research on that is needed to work out how best to provide single port multiplexing functionality in the Operator and how that affects areas such as the engine, Ambassador, and Istio.

Further changes to the Operator would likely need to propagate all the way to the CRD for them to be useful. Clearly this is quite an expansive body of work which needs to be split up further to be able to be tackled properly.

However, as was the goal of this Issue, the Executor as a standalone is now multiplexing on the single --port flag given.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants