Add executor changes for HTTP/gRPC multiplexing #1772

glindsell · 2020-04-30T16:17:18Z

Executor changes work when tested locally.
Operator changes still needed.

Signed-off-by: glindsell gl@seldon.io

Signed-off-by: glindsell <gl@seldon.io>

seldondev · 2020-04-30T16:18:28Z

Thu Apr 30 16:18:28 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1772/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1772 --build=1

seldondev · 2020-04-30T16:18:36Z

Thu Apr 30 16:18:35 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1772/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1772 --build=2

glindsell · 2020-05-01T13:34:22Z

/test integration

seldondev · 2020-05-01T13:35:33Z

Fri May 1 13:35:32 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1772/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1772 --build=3

Signed-off-by: glindsell <gl@seldon.io>

seldondev · 2020-05-01T13:56:36Z

Fri May 1 13:56:35 UTC 2020
The logs for [pr-build] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1772/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1772 --build=4

seldondev · 2020-05-01T13:56:38Z

Fri May 1 13:56:37 UTC 2020
The logs for [lint] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1772/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1772 --build=5

glindsell · 2020-05-01T15:19:11Z

/retest

seldondev · 2020-05-01T15:20:37Z

Fri May 1 15:20:37 UTC 2020
The logs for [pr-build] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1772/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1772 --build=6

glindsell · 2020-05-04T09:00:33Z

/test integration

seldondev · 2020-05-04T09:01:46Z

Mon May 4 09:01:45 UTC 2020
The logs for [integration] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1772/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1772 --build=7

glindsell · 2020-05-05T13:12:05Z

/test integration

seldondev · 2020-05-05T13:13:31Z

Tue May 5 13:13:30 UTC 2020
The logs for [integration] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1772/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1772 --build=8

Signed-off-by: glindsell <gl@seldon.io>

seldondev · 2020-05-06T08:58:28Z

Wed May 6 08:58:27 UTC 2020
The logs for [lint] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1772/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1772 --build=10

seldondev · 2020-05-06T08:58:31Z

Wed May 6 08:58:30 UTC 2020
The logs for [pr-build] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1772/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1772 --build=9

glindsell · 2020-05-06T09:44:25Z

/retest

seldondev · 2020-05-06T09:45:41Z

Wed May 6 09:45:40 UTC 2020
The logs for [pr-build] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1772/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1772 --build=11

glindsell · 2020-05-07T08:18:38Z

/test integration

seldondev · 2020-05-07T08:19:50Z

Thu May 7 08:19:49 UTC 2020
The logs for [integration] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1772/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1772 --build=12

Signed-off-by: glindsell <gl@seldon.io>

seldondev · 2020-05-11T14:05:28Z

Mon May 11 14:05:27 UTC 2020
The logs for [pr-build] [13] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1772/13.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1772 --build=13

seldondev · 2020-05-11T14:06:39Z

Mon May 11 14:06:38 UTC 2020
The logs for [lint] [14] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1772/14.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1772 --build=14

glindsell · 2020-05-11T14:24:04Z

/test integration

seldondev · 2020-05-18T15:45:44Z

Mon May 18 15:45:43 UTC 2020
The logs for [integration] [35] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1772/35.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1772 --build=35

glindsell · 2020-05-19T12:41:10Z

/test integration

seldondev · 2020-05-19T12:42:25Z

Tue May 19 12:42:24 UTC 2020
The logs for [integration] [36] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1772/36.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1772 --build=36

glindsell · 2020-05-20T08:14:19Z

/test integration

seldondev · 2020-05-20T08:15:43Z

Wed May 20 08:15:41 UTC 2020
The logs for [integration] [37] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1772/37.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1772 --build=37

glindsell · 2020-05-20T09:54:06Z

/test integration

seldondev · 2020-05-20T09:55:34Z

Wed May 20 09:55:30 UTC 2020
The logs for [integration] [38] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1772/38.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1772 --build=38

glindsell · 2020-05-20T13:18:04Z

/test integration

seldondev · 2020-05-20T13:19:22Z

Wed May 20 13:19:18 UTC 2020
The logs for [integration] [39] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1772/39.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1772 --build=39

ukclivecox · 2020-05-20T16:36:39Z

/approve

seldondev · 2020-05-20T16:36:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [cliveseldon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

seldondev · 2020-05-21T11:08:00Z

Thu May 21 11:07:56 UTC 2020
The logs for [pr-build] [40] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1772/40.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1772 --build=40

seldondev · 2020-05-21T11:08:26Z

Thu May 21 11:08:25 UTC 2020
The logs for [lint] [41] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1772/41.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1772 --build=41

seldondev · 2020-05-25T07:16:21Z

Mon May 25 07:16:16 UTC 2020
The logs for [lint] [45] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1772/45.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1772 --build=45

seldondev · 2020-05-25T07:16:21Z

Mon May 25 07:16:18 UTC 2020
The logs for [pr-build] [44] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1772/44.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1772 --build=44

seldondev · 2020-05-26T08:42:11Z

Tue May 26 08:42:10 UTC 2020
The logs for [lint] [49] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1772/49.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1772 --build=49

seldondev · 2020-05-26T08:42:17Z

Tue May 26 08:42:16 UTC 2020
The logs for [pr-build] [48] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1772/48.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1772 --build=48

This reverts commit ad5b6a5.

* Revert "Add executor changes for HTTP/gRPC multiplexing (#1772)" This reverts commit ad5b6a5. * Fix executor main conflict Signed-off-by: glindsell <gl@seldon.io> * Remove reduntant code in executor main Signed-off-by: glindsell <gl@seldon.io> * Fix log message Signed-off-by: glindsell <gl@seldon.io> * Move Kafka serving Signed-off-by: glindsell <gl@seldon.io> * remove grpcurl dependency Signed-off-by: glindsell <gl@seldon.io> * Reintroduce getExecutorGrpcPort Signed-off-by: glindsell <gl@seldon.io> * Add missing constants from operator seldondeployment engine Signed-off-by: glindsell <gl@seldon.io> * Remove port selection for executor in operator and change port name to grpc Signed-off-by: glindsell <gl@seldon.io> * go mod tidy Signed-off-by: glindsell <gl@seldon.io> * go.mod go.sum and licenses changes Signed-off-by: glindsell <gl@seldon.io> * Add transport grpc to metadata grpc test Signed-off-by: glindsell <gl@seldon.io>

seldondev · 2021-05-13T06:38:30Z

failed to trigger Pull Request pipeline

failed to create agent
failed to calculate in repo config
failed to load trigger config for repository SeldonIO/seldon-core for ref 82eac94
failed to find any lighthouse configuration files in repo SeldonIO/seldon-core at sha 82eac94
failed to process repo SeldonIO/seldon-core refref 82eac94
failed to list files in directory /var/tmp/gitrepo660600678/.lighthouse
open /var/tmp/gitrepo660600678/.lighthouse
no such file or directory

Add executor changes for HTTP/gRPC multiplexing

0a9064e

Signed-off-by: glindsell <gl@seldon.io>

glindsell requested a review from ukclivecox April 30, 2020 16:17

seldondev added the do-not-merge/work-in-progress label Apr 30, 2020

glindsell marked this pull request as draft April 30, 2020 16:17

seldondev added the size/L label Apr 30, 2020

glindsell mentioned this pull request Apr 30, 2020

Multiplex HTTP and gRPC on the executor #1762

Closed

Remove gRPC port for executor container creation in operator

2e766a2

Signed-off-by: glindsell <gl@seldon.io>

Close executor listener

2b7f398

Signed-off-by: glindsell <gl@seldon.io>

Remove transport flag from operator controller

3c474ad

Signed-off-by: glindsell <gl@seldon.io>

glindsell mentioned this pull request May 20, 2020

Remove probesonly flag #1856

Closed

seldondev added approved and removed do-not-merge/work-in-progress labels May 20, 2020

glindsell merged commit ad5b6a5 into SeldonIO:master May 26, 2020

This was referenced May 28, 2020

Metrics notebook broken (gRPC) #1886

Closed

Add benchmarks soheilhy/cmux#75

Open

glindsell mentioned this pull request Jun 4, 2020

Multiplex Http and gRPC traffic #1628

Closed

glindsell pushed a commit to glindsell/seldon-core that referenced this pull request Sep 2, 2020

Revert "Add executor changes for HTTP/gRPC multiplexing (SeldonIO#1772)"

c6ee04c

This reverts commit ad5b6a5.

This was referenced Sep 2, 2020

Revert multiplexing in the Executor #2364

Closed

Revert multiplexing in the Executor #2365

Merged

axsaucedo unassigned ukclivecox May 13, 2021

Add executor changes for HTTP/gRPC multiplexing #1772

Add executor changes for HTTP/gRPC multiplexing #1772

Conversation

glindsell commented Apr 30, 2020 • edited by ukclivecox Loading

seldondev commented Apr 30, 2020

seldondev commented Apr 30, 2020

glindsell commented May 1, 2020

seldondev commented May 1, 2020

seldondev commented May 1, 2020

seldondev commented May 1, 2020

glindsell commented May 1, 2020

seldondev commented May 1, 2020

glindsell commented May 4, 2020

seldondev commented May 4, 2020

glindsell commented May 5, 2020

seldondev commented May 5, 2020

seldondev commented May 6, 2020

seldondev commented May 6, 2020

glindsell commented May 6, 2020

seldondev commented May 6, 2020

glindsell commented May 7, 2020

seldondev commented May 7, 2020

seldondev commented May 11, 2020

seldondev commented May 11, 2020

glindsell commented May 11, 2020

seldondev commented May 18, 2020

glindsell commented May 19, 2020

seldondev commented May 19, 2020

glindsell commented May 20, 2020

seldondev commented May 20, 2020

glindsell commented May 20, 2020

seldondev commented May 20, 2020

glindsell commented May 20, 2020

seldondev commented May 20, 2020

ukclivecox commented May 20, 2020

seldondev commented May 20, 2020

seldondev commented May 21, 2020

seldondev commented May 21, 2020

seldondev commented May 25, 2020

seldondev commented May 25, 2020

seldondev commented May 26, 2020

seldondev commented May 26, 2020

seldondev commented May 13, 2021

glindsell commented Apr 30, 2020 •

edited by ukclivecox

Loading