Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics notebook broken (gRPC) #1886

Closed
glindsell opened this issue May 28, 2020 · 1 comment · Fixed by #1892
Closed

Metrics notebook broken (gRPC) #1886

glindsell opened this issue May 28, 2020 · 1 comment · Fixed by #1892
Assignees
Labels
Milestone

Comments

@glindsell
Copy link
Contributor

https://github.com/SeldonIO/seldon-core/blob/master/examples/models/metrics/metrics.ipynb

... is broken.

Due to #1772 which introduced gRPC/HTTP multiplexing on the Executor. These changes mean that the Executor is created by the operator on port 8000 OR 5001 and all traffic (gRPC and HTTP) goes through one of those ports.

The executor used to be running on ports 8000 AND 5001. Thus the metrics example notebook looks for metrics on port 8000 in the gRPC example - when they are in fact running on port 5001.

This can be fixed by bringing the operator in line with the executor in regard to multiplexing.

Please see #1628

@glindsell glindsell added bug triage Needs to be triaged and prioritised accordingly labels May 28, 2020
@glindsell glindsell self-assigned this May 28, 2020
@RafalSkolasinski
Copy link
Contributor

I believe that having executor always serve traffic in same port, like always 8000, will pay off in a long run by removing ambiguity and confusion.

Whatever we choose we need to make sure that ambassador / istio are directing traffic to the right ports.

@ukclivecox ukclivecox added this to the 1.2 milestone May 28, 2020
@ukclivecox ukclivecox removed the triage Needs to be triaged and prioritised accordingly label May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants