Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make feedback more flexible and light #337

Closed
jklaise opened this issue Dec 10, 2018 — with Board Genius Sync · 4 comments
Closed

Make feedback more flexible and light #337

jklaise opened this issue Dec 10, 2018 — with Board Genius Sync · 4 comments
Labels
area/routing External API lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. Reinforcement Learning
Milestone

Comments

Copy link
Contributor

jklaise commented Dec 10, 2018

Currently the send-feedback API takes in a batch of samples (request+response) but only one float for the reward which means that design choices must be made when distributing this reward between all samples in the batch (e.g. #336). One potential fix would be to change reward to be of type DefaultData so that each sample in a batch gets its own reward.

Additionally, we need to re-evaluate sending both request and response as part of the feedback as this could be wasteful with large payloads.

@janvdvegt
Copy link

I agree with both statements, aggregating up front seems like throwing away information unnecessarily and shutting off options for more elaborate choices. Aggregating them later if needed seems better.

With regards to the request and response, would there be a possibility to send a unique identifier instead of the full request if needed? That way we could still have a full audit to link the reward to an earlier request but not have to send the full input multiple times. In other places I also believe that using an identifier instead of the full payload is useful.

@ukclivecox
Copy link
Contributor

Related to new spec in https://github.com/SeldonIO/mlgraph

@ukclivecox ukclivecox modified the milestones: 0.3.x, 2.0.x Aug 23, 2019
@seldondev
Copy link
Collaborator

Issues go stale after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
/lifecycle stale

@seldondev seldondev added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 17, 2020
@axsaucedo axsaucedo changed the title Make feedback more flexible and light OSS-2: Make feedback more flexible and light Apr 26, 2021
@axsaucedo axsaucedo changed the title OSS-2: Make feedback more flexible and light Make feedback more flexible and light Apr 28, 2021
@ukclivecox
Copy link
Contributor

Iter8 integration allows for more flexible usage now. We will work further on this for v2.

agrski pushed a commit that referenced this issue Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/routing External API lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. Reinforcement Learning
Projects
None yet
Development

No branches or pull requests

4 participants