Additional parameter types Seldon deployment proto #456
Labels
Comments
|
Unlikely to be done until we revamp the way graphs/DAGs are specified. Will close. https://github.com/SeldonIO/mlgraph |
agrski
added a commit
that referenced
this issue
Dec 2, 2022
* Add log level option to CLI package * Propagate log level from args to logging configuration * Add default log level in properties * Fix invalid use of lowercase log level name in default properties * Log full application config on start-up * Formatting * Rename log level config var to disambiguate * Add log level config for Kafka * Remove unused imports * Try to deduplicate config entries before logging at start-up * Add func retrieving list of all CLI args * Simplify CLI arg parsing using list of known args * Log effective CLI arg values on startup It is helpful to know what configuration an application thinks it is starting with. However, Konfig's 'toList()' method on composite configuration objects tells us about all the underlying configurations, without telling us which one is actually in use. This approach overcomes that limitation, at the cost of a little more bookkeeping on the CLI side. * Move CLI args accessor to alongside arg definitions By keeping these visually close, it helps to mitigate the risk that someone adds a new arg without adding it to the list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It would be helpful to allow parameter types like LIST and DICT in the deployment proto.
The text was updated successfully, but these errors were encountered: