Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default ambassador chart to single namespace #495

Closed
ryandawsonuk opened this issue Apr 8, 2019 · 0 comments · Fixed by #509
Closed

default ambassador chart to single namespace #495

ryandawsonuk opened this issue Apr 8, 2019 · 0 comments · Fixed by #509
Labels
Ambassador area/Helm

Comments

@ryandawsonuk
Copy link
Contributor

We use --set ambassador.env.AMBASSADOR_SINGLE_NAMESPACE=true in a lot of our examples. You can see this by searching the repo - it was introduced in #480

At the time we couldn't default the ambassador helm chart to a single namespace. But now we can as helm/charts#12670 has been merged

So we can upgrade to that version of the chart and set single namespace as the default. Then we can remove all those instances of setting the env var to true. Instead we'd need to set the new scope.singleNamespace to false for the cluster-wide cases
@ryandawsonuk ryandawsonuk changed the title default helm chart to single namespace default ambassador chart to single namespace Apr 8, 2019
@ryandawsonuk ryandawsonuk mentioned this issue Apr 11, 2019
Merged
agrski pushed a commit that referenced this issue Dec 2, 2022
@ukclivecox
Add ssl_verify_path for explainer TLS (#495)
feaf14d 
* revert REQUESTS_CA_BUNDLE

* add ssl_verify_path to mlserver explainer settings

* MLServer dev7 update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Ambassador area/Helm
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

default ambassador to singleNamespace SeldonIO/seldon-core
1 participant
@ryandawsonuk