Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update redis requirement from <3.0.0 to <4.0.0 in /python #1053

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

dependabot-preview[bot]
Copy link
Contributor

Updates the requirements on redis to permit the latest version.

Changelog

Sourced from redis's changelog.

  • 3.3.11
    • Further fix for the SSLError -> TimeoutError mapping to work
      on obscure releases of Python 2.7.
  • 3.3.10
    • Fixed a potential error handling bug for the SSLError -> TimeoutError
      mapping introduced in 3.3.9. Thanks @​zbristow. #1224
  • 3.3.9
    • Mapped Python 2.7 SSLError to TimeoutError where appropriate. Timeouts
      should now consistently raise TimeoutErrors on Python 2.7 for both
      unsecured and secured connections. Thanks @​zbristow. #1222
  • 3.3.8
    • Fixed MONITOR parsing to properly parse IPv6 client addresses, unix
      socket connections and commands issued from Lua. Thanks @​kukey. #1201
  • 3.3.7
    • Fixed a regression introduced in 3.3.0 where socket.error exceptions
      (or subclasses) could potentially be raised instead of
      redis.exceptions.ConnectionError. #1202
  • 3.3.6
    • Fixed a regression in 3.3.5 that caused PubSub.get_message() to raise
      a socket.timeout exception when passing a timeout value. #1200
  • 3.3.5
    • Fix an issue where socket.timeout errors could be handled by the wrong
      exception handler in Python 2.7.
  • 3.3.4
    • More specifically identify nonblocking read errors for both SSL and
      non-SSL connections. 3.3.1, 3.3.2 and 3.3.3 on Python 2.7 could
      potentially mask a ConnectionError. #1197
  • 3.3.3
    • The SSL module in Python < 2.7.9 handles non-blocking sockets
      differently than 2.7.9+. This patch accommodates older versions. #1197
  • 3.3.2
    • Further fixed a regression introduced in 3.3.0 involving SSL and
      non-blocking sockets. #1197
  • 3.3.1
    • Fixed a regression introduced in 3.3.0 involving SSL and non-blocking
      sockets. #1197
  • 3.3.0
    • Resolve a race condition with the PubSubWorkerThread. #1150
    • Cleanup socket read error messages. Thanks Vic Yu. #1159
    • Cleanup the Connection's selector correctly. Thanks Bruce Merry. #1153
    • Added a Monitor object to make working with MONITOR output easy.
      Thanks Roey Prat #1033
    • Internal cleanup: Removed the legacy Token class which was necessary
      with older version of Python that are no longer supported. #1066
    • Response callbacks are now case insensitive. This allows users that
      call Redis.execute_command() directly to pass lower-case command
      names and still get reasonable responses. #1168
    • Added support for hiredis-py 1.0.0 encoding error support. This should
      make the PythonParser and the HiredisParser behave identically
      when encountering encoding errors. Thanks Brian Candler. #1161/#1162
... (truncated)
Commits
  • 5377285 Version 3.3.11
  • e1bc385 Version 3.3.10
  • a03c12e Version 3.3.9
  • 29a5259 spelling fixes (#1218)
  • d811ae7 version 3.3.8, fix MONITOR output to account for all types of clients
  • f0516c9 version 3.3.7, Fixed a socket.error regression introduced in 3.3.0
  • 038e5ee version 3.3.6, fixed a regression in 3.3.5 with pubsub timeouts
  • a5ba696 version 3.3.5, handle socket.timeout errors correctly in Python 2.7
  • 3afa016 version 3.3.4, more specifically identify nonblocking read errors
  • 885ce77 version 3.3.4, more specifically identify nonblocking read errors
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking Bump now in your Dependabot dashboard.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Updates the requirements on [redis](https://github.com/andymccurdy/redis-py) to permit the latest version.
- [Release notes](https://github.com/andymccurdy/redis-py/releases)
- [Changelog](https://github.com/andymccurdy/redis-py/blob/master/CHANGES)
- [Commits](redis/redis-py@2.4.6...3.3.11)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file Python labels Nov 5, 2019
@seldondev
Copy link
Collaborator

Hi @dependabot-preview[bot]. Thanks for your PR.

I'm waiting for a SeldonIO or seldonio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adriangonz
Copy link
Contributor

/ok-to-test

Sent with GitHawk

@adriangonz
Copy link
Contributor

I've had a look at the breaking changes listed here and it all seems good. However, I'm not too familiar with the persistence feature of seldon-core.

Do you think this update should affect us in any way @jklaise @cliveseldon?

@adriangonz
Copy link
Contributor

/cc @cliveseldon @jklaise

@ukclivecox
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit 287937d into master Nov 14, 2019
@dependabot-preview dependabot-preview bot deleted the dependabot/pip/python/redis-lt-4.0.0 branch November 14, 2019 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dependencies Pull requests that update a dependency file ok-to-test Python size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants