Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump pb.version from 3.10.0 to 3.11.1 in /engine #1216

Merged
merged 1 commit into from
Dec 11, 2019
Merged

Bump pb.version from 3.10.0 to 3.11.1 in /engine #1216

merged 1 commit into from
Dec 11, 2019

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps pb.version from 3.10.0 to 3.11.1.

Updates protobuf-java from 3.10.0 to 3.11.1

Release notes

Sourced from protobuf-java's releases.

Protocol Buffers v3.11.1

PHP

  • Extern declare protobuf_globals (#6946)

Protocol Buffers v3.11.0

C++

  • Make serialization method naming consistent
  • Make proto runtime + generated code free of deprecation warnings
  • Moved ShutdownProtobufLibrary() to message_lite.h. For backward compatibility a declaration is still available in stubs/common.h, but users should prefer message_lite.h
  • Removed non-namespace macro EXPECT_OK()
  • Removed mathlimits.h from stubs in favor of using std::numeric_limits from C++11
  • Fixed bug in parser when ending on a group tag
  • Add a helper function to UnknownFieldSet to deal with the changing return value of message::unknown_fields()
  • Fix incorrect use of string_view iterators
  • Support direct pickling of nested messages
  • Skip extension tag validation for MessageSet if unknown dependencies are allowed
  • Updated deprecation macros to annotate deprecated code (#6612)
  • Remove conversion warning in MapEntryFuncs::ByteSizeLong (#6766)
  • Revert "Make shared libraries be able to link to MSVC static runtime libraries, so that VC runtime is not required." (#6914)

Java

  • Remove the usage of MethodHandle, so that Android users prior to API version 26 can use protobuf-java
  • Publish ProGuard config for javalite
  • Fix for StrictMode disk read violation in ExtensionRegistryLite
  • Include part of the ByteString's content in its toString().
  • Include unknown fields when merging proto3 messages in Java lite builders

Python

  • Add float_precision option in json format printer
  • Optionally print bytes fields as messages in unknown fields, if possible
  • FieldPath: fix testing IsSet on root path ''
  • Experimental code gen (fast import protobuf module) which only work with cpp generated code linked in

JavaScript

  • Remove guard for Symbol iterator for jspb.Map

PHP

  • Avoid too much overhead in layout_init (#6716)
  • Lazily Create Singular Wrapper Message (#6833)
  • Implement lazy loading of php class for proto messages (#6911)

Ruby

  • Ruby lazy wrappers optimization (#6797)
... (truncated)
Commits

Updates protobuf-java-util from 3.10.0 to 3.11.1

Release notes

Sourced from protobuf-java-util's releases.

Protocol Buffers v3.11.1

PHP

  • Extern declare protobuf_globals (#6946)

Protocol Buffers v3.11.0

C++

  • Make serialization method naming consistent
  • Make proto runtime + generated code free of deprecation warnings
  • Moved ShutdownProtobufLibrary() to message_lite.h. For backward compatibility a declaration is still available in stubs/common.h, but users should prefer message_lite.h
  • Removed non-namespace macro EXPECT_OK()
  • Removed mathlimits.h from stubs in favor of using std::numeric_limits from C++11
  • Fixed bug in parser when ending on a group tag
  • Add a helper function to UnknownFieldSet to deal with the changing return value of message::unknown_fields()
  • Fix incorrect use of string_view iterators
  • Support direct pickling of nested messages
  • Skip extension tag validation for MessageSet if unknown dependencies are allowed
  • Updated deprecation macros to annotate deprecated code (#6612)
  • Remove conversion warning in MapEntryFuncs::ByteSizeLong (#6766)
  • Revert "Make shared libraries be able to link to MSVC static runtime libraries, so that VC runtime is not required." (#6914)

Java

  • Remove the usage of MethodHandle, so that Android users prior to API version 26 can use protobuf-java
  • Publish ProGuard config for javalite
  • Fix for StrictMode disk read violation in ExtensionRegistryLite
  • Include part of the ByteString's content in its toString().
  • Include unknown fields when merging proto3 messages in Java lite builders

Python

  • Add float_precision option in json format printer
  • Optionally print bytes fields as messages in unknown fields, if possible
  • FieldPath: fix testing IsSet on root path ''
  • Experimental code gen (fast import protobuf module) which only work with cpp generated code linked in

JavaScript

  • Remove guard for Symbol iterator for jspb.Map

PHP

  • Avoid too much overhead in layout_init (#6716)
  • Lazily Create Singular Wrapper Message (#6833)
  • Implement lazy loading of php class for proto messages (#6911)

Ruby

  • Ruby lazy wrappers optimization (#6797)
... (truncated)
Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview
Bump pb.version from 3.10.0 to 3.11.1 in /engine
31a8d4b 
Bumps `pb.version` from 3.10.0 to 3.11.1.

Updates `protobuf-java` from 3.10.0 to 3.11.1
- [Release notes](https://github.com/protocolbuffers/protobuf/releases)
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/master/generate_changelog.py)
- [Commits](protocolbuffers/protobuf@v3.10.0...v3.11.1)

Updates `protobuf-java-util` from 3.10.0 to 3.11.1
- [Release notes](https://github.com/protocolbuffers/protobuf/releases)
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/master/generate_changelog.py)
- [Commits](protocolbuffers/protobuf@v3.10.0...v3.11.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file Java labels Dec 9, 2019
@dependabot-preview dependabot-preview bot mentioned this pull request Dec 9, 2019
Closed
@seldondev seldondev requested review from arnaudvl and gsunner December 9, 2019 07:35
@seldondev
Copy link
Collaborator

Hi @dependabot-preview[bot]. Thanks for your PR.

I'm waiting for a SeldonIO or seldonio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adriangonz
Copy link
Contributor

/ok-to-test
/test integration

@seldondev
Copy link
Collaborator

Mon Dec 9 09:12:20 UTC 2019
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1216/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1216 --build=1

@seldondev
Copy link
Collaborator

Mon Dec 9 09:12:32 UTC 2019
The logs for [integration] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1216/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1216 --build=2

@seldondev
Copy link
Collaborator

Mon Dec 9 09:12:43 UTC 2019
The logs for [lint] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1216/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1216 --build=3

@adriangonz
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

Tue Dec 10 17:53:22 UTC 2019
The logs for [integration] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1216/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1216 --build=4

@seldondev
Copy link
Collaborator

@dependabot-preview[bot]: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integration 31a8d4b link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@adriangonz
Copy link
Contributor

/approve

The only integration tests failing seem to be the intermittent 503 errors.

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriangonz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adriangonz adriangonz merged commit 151fe2c into master Dec 11, 2019
@adriangonz adriangonz deleted the dependabot/maven/engine/pb.version-3.11.1 branch December 11, 2019 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaudvl arnaudvl Awaiting requested review from arnaudvl

@gsunner gsunner Awaiting requested review from gsunner

Assignees
No one assigned
Labels
approved dependencies Pull requests that update a dependency file Java ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seldondev @adriangonz