Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Clientset for seldon operator" #1240

Merged
merged 1 commit into from
Dec 11, 2019
Merged

Conversation

ryandawsonuk
Copy link
Contributor

Reverts #1221

We're now seeing below in the build

Error: not all generators ran successfully
run `controller-gen object:headerFile=./hack/boilerplate.go.txt paths=./... -w` to see all available markers, or `controller-gen object:headerFile=./hack/boilerplate.go.txt paths=./... -h` for usage

@seldondev
Copy link
Collaborator

Wed Dec 11 12:12:52 UTC 2019
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1240/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1240 --build=1

@seldondev
Copy link
Collaborator

Wed Dec 11 12:13:04 UTC 2019
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1240/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1240 --build=2

@adriangonz
Copy link
Contributor

/approve

Looks good to me!

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriangonz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit 2336923 into master Dec 11, 2019
@RafalSkolasinski RafalSkolasinski deleted the revert-1221-clientset branch February 21, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants