Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforce tensorflow<2.0 in Tensorflow MNIST Model example #1251

Merged
merged 1 commit into from
Dec 12, 2019
Merged

enforce tensorflow<2.0 in Tensorflow MNIST Model example #1251

merged 1 commit into from
Dec 12, 2019

Conversation

RafalSkolasinski
Copy link
Contributor

This example is incompatible with Tensorflow 2.0, therefore enforcing a lower version.

@seldondev
Copy link
Collaborator

Hi @RafalSkolasinski. Thanks for your PR.

I'm waiting for a SeldonIO or seldonio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@RafalSkolasinski
Copy link
Contributor Author

/assign @axsaucedo

@axsaucedo
Copy link
Contributor

Nice one!
/ok-to-test
/approve
/lgtm

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Thu Dec 12 13:38:34 UTC 2019
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1251/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1251 --build=1

@seldondev
Copy link
Collaborator

Thu Dec 12 13:38:38 UTC 2019
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1251/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1251 --build=2

@seldondev seldondev merged commit f471318 into SeldonIO:master Dec 12, 2019
@RafalSkolasinski RafalSkolasinski deleted the example_patch branch December 12, 2019 13:46
@axsaucedo axsaucedo removed their assignment May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants