Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up duplicated code for types and webhooks #1296

Merged
merged 1 commit into from
Dec 20, 2019
Merged

Clean up duplicated code for types and webhooks #1296

merged 1 commit into from
Dec 20, 2019

Conversation

ukclivecox
Copy link
Contributor

Fixes #1294

@seldondev seldondev requested review from gipster and jklaise December 19, 2019 19:34
@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Thu Dec 19 19:35:10 UTC 2019
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1296/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1296 --build=1

@seldondev
Copy link
Collaborator

Thu Dec 19 19:35:19 UTC 2019
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1296/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1296 --build=2

@seldondev
Copy link
Collaborator

Thu Dec 19 19:35:42 UTC 2019
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1296/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1296 --build=3

@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Fri Dec 20 09:18:35 UTC 2019
The logs for [integration] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1296/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1296 --build=4

@ryandawsonuk
Copy link
Contributor

/lgtm
/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ryandawsonuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit cbbcc5a into SeldonIO:master Dec 20, 2019
@ukclivecox ukclivecox deleted the 1294_api_cleanup branch December 20, 2019 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up API types and Webhooks
3 participants